[React] Improve fetch #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

soyuka merged 2 commits into api-platform:master from dunglas:improve-fetch

Sep 17, 2019

Member

dunglas commented May 23, 2019

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Add support for fields having several errors
Throw a better error message when the server returns invalid JSON


          [React] Improve fetch

e88cfa7

dunglas commented

View reviewed changes

templates/react-common/utils/dataAccess.js Outdated

    
                    throw new SubmissionError(errors);

                  })

                  .catch(() => {

Member Author

dunglas May 25, 2019

Not ok, we should detect if it's a SubmissionError first


          Better implem

140a580

soyuka merged commit d5ccc01 into api-platform:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet