feat: authorize localhost call to demo api #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid CORS rejection when using client-generator we should enable this kind of origins
dunglas
approved these changes
May 20, 2019
teohhanhui
reviewed
May 21, 2019
| debug: '0' | ||
| secret: "" | ||
| corsAllowOrigin: "^https?://.*?\\.api-platform\\.com$" | ||
| corsAllowOrigin: "^https?://(.*?api-platform\\.com|localhost(?::[0-9]+)?)$" |
Contributor
There was a problem hiding this comment.
Now fakeapi-platform.com is allowed! 😝
Contributor
Author
There was a problem hiding this comment.
Now? It was already possible.
Member
There was a problem hiding this comment.
No it wasn't because of the \. part. Indeed we must add it back.
Member
There was a problem hiding this comment.
We don't call the demo from api-platform.com, so https://regex101.com/r/EA7Gzu/5 is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid CORS rejection when using client-generator we should enable this kind of origins
For info: regex battery test -> https://regex101.com/r/3CUlV8/2