Skip to content

feat: authorize localhost call to demo api #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2019
Merged

feat: authorize localhost call to demo api #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/helm/api/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ php:
env: prod
debug: '0'
secret: ""
corsAllowOrigin: "^https?://.*?\\.api-platform\\.com$"
corsAllowOrigin: "^https?://(.*?api-platform\\.com|localhost(?::[0-9]+)?)$"
Copy link
Contributor

@teohhanhui teohhanhui May 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now fakeapi-platform.com is allowed! 😝

https://regex101.com/r/EA7Gzu/2

Copy link
Contributor Author

@Gregcop1 Gregcop1 May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now? It was already possible.

Copy link
Member

@dunglas dunglas May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it wasn't because of the \. part. Indeed we must add it back.

Copy link
Contributor

@teohhanhui teohhanhui May 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed regex: https://regex101.com/r/EA7Gzu/4

Copy link
Member

@dunglas dunglas May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't call the demo from api-platform.com, so https://regex101.com/r/EA7Gzu/5 is enough.

Copy link
Contributor

@teohhanhui teohhanhui May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better: https://regex101.com/r/EA7Gzu/6

trustedHosts: "^.*\\.api\\-platform\\.com$"
trustedProxies:
- 103.21.244.0/22
Expand Down