Skip undeterministic deployment verification - #807
Open
hiletmis wants to merge 2 commits into
Open
Conversation
…proved deployment validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #461
Problem
verify-deploymentsfails on both Filecoin chains:All contracts on these two chains are deployed undeterministically, so they are verified
through their creation transactions. Filecoin's Ethereum JSON-RPC implementation only
indexes recent messages, which means
eth_getTransactionByHashreturnsnullfor thedeployment transactions and verification cannot proceed.
This is a property of the chains' RPC retention rather than a problem with the
deployments themselves.
Solution
Add
skippedChainAliasesInUndeterministicDeploymentVerificationtoscripts/constants.ts,following the existing skip-list convention in that file. For the listed chains,
verify-deploymentsconfirms that contract code exists at the deployment address insteadof fetching and comparing the creation transaction.