-
Notifications
You must be signed in to change notification settings - Fork 6
fix(deps): update dependency zod to v4 #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8636c12 to
26cb376
Compare
00083e0 to
34c5cf4
Compare
34c5cf4 to
2b29560
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| message: "Unrecognized key(s) in object: 'strange'", | ||
| }, | ||
| ]), | ||
| errors: expect.any(ZodError), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a new test in schema.test.ts for this.
|
FYI @Siegrift I have again solely relied on the CI for testing. The |
Yeah, should be okey. |
Siegrift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM (just one comment)
|
|
||
| import packageJson from '../../package.json'; | ||
|
|
||
| export const evmIdSchema = z.string().regex(/^0x[a-fA-F0-9]{64}$/); // eslint-disable-line unicorn/better-regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not import commons for these validations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI these were previously imported from @api3/airnode-validator airnode/packages/airnode-validator/src/config/config.ts#L14 (which is still using zod v3).
commons is still pending its review + release (Derek will get to it soon), so we could hold off merging this PR until then I guess. Are you suggesting we use the keccak256HashSchema from commons instead of this evmIdSchema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do export const evmIdSchema = keccak256HashSchema and yeah, I'd wait until commons is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked into this and I logged a separate task for it because it affects a fair amount of code: #498
This PR contains the following updates:
^3.25.76->^4.0.5Release Notes
colinhacks/zod (zod)
v4.0.5Compare Source
v4.0.4Compare Source
v4.0.3Compare Source
v4.0.2Compare Source
v4.0.1Compare Source
Commits:
91c9ca6fix: cleanup _idmap of $ZodRegistry (#4837)9cce1c5docs: fix typo in flattenError example on error-formatting page (#4819) (#4833)a3560aev3.25.76 (#4838)5060661Release 3.25.767baee4eUpdate index.mdx (#4831)06172bfdocs: add zod2md to zodToXConverters (#4835)30e2f3eUpdate docsb748b91Add zod-openapi libraries to v4 (#4829)990e03bUpdate core.mdx (#4746)e7f20c2Fix treeifyError type for branded primitives. Add test. Closes #4840 (#4843)79d4d80v4.0.0 (#4844)00a1708Remove JSR from release.yml7c4c83cUpdate mime docsa7bd58aRemove when from paramse899016Support format in z.templateLiteralb2592114.0.1v4.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.