chore(obs): retire the DP-side real-SLS smoke test (moved to CP) - #537
Conversation
The real-credential Aliyun SLS validation now lives on the control plane (api7/AISIX-Cloud) as a full-chain e2e: configure an aliyun_sls exporter via cp-api → boot a live DP → fire a real chat → read the request-event back from the real logstore. That exercises the whole user path (dashboard/cp-api config → kine → DP → upstream → SLS), which the DP-isolated smoke could not. Removes the now-dead `mod smoke` (sls_smoke_putlogs_and_readback + readback/response_contains helpers) and its `aliyun sls smoke (real)` CI job. The SLS secrets have already been migrated from this repo's CI to the CP's. The DP's mock-SLS L2 e2e (sink mechanics: v1 signature / lz4 block / protobuf wire) is unaffected and remains the DP-side coverage. Refs: #528, #532, api7/AISIX-Cloud#708
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRemoved the ChangesSLS Smoke Test Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. Comment |
Audit LOW: the mock-SLS exporter e2e's header referenced the real-SLS smoke this PR removes; point it at the control-plane full-chain e2e instead.
What
Removes the DP-side real-Aliyun-SLS smoke test (
mod smokeincrates/aisix-obs/src/sink/sls.rs—sls_smoke_putlogs_and_readback+ itsreadback/response_containshelpers) and itsaliyun sls smoke (real)CI job.Why
The real-credential SLS validation has moved to the control plane (api7/AISIX-Cloud#709) as a full-chain e2e: configure an
aliyun_slsexporter via cp-api → boot a live DP → fire a real chat → read the request-event back from the real logstore. That exercises the actual user path (dashboard/cp-api config → kine → DP → upstream → SLS), which a DP-isolated smoke test cannot. The CP is where the whole feature integrates, so it's the right home for the real-credential check.The org's SLS CI secrets (
ALI_SLS_AK_ID/ALI_SLS_SK) have already been migrated from this repo to the CP.Scope / safety
#[cfg(test)]and#[ignore]-gated — it never ran in the normal suite. Its helpers (readback,response_contains,env) were used only within it.cargo clippy -p aisix-obs --all-targets -- -D warningsis clean — the production helpers the smoke test referenced (base_url_for,now_unix_secs,AliyunSlsSink) remain used by the sink + the regular unit tests, so nothing is orphaned.needs:the removed CI job.mock-sls) is unaffected and remains the DP-side coverage.Refs: #528, #532, api7/AISIX-Cloud#708, api7/AISIX-Cloud#709
Summary by CodeRabbit