Skip to content

chore(obs): retire the DP-side real-SLS smoke test (moved to CP) - #537

Merged
moonming merged 2 commits into
mainfrom
chore/retire-dp-sls-smoke
Jun 8, 2026
Merged

chore(obs): retire the DP-side real-SLS smoke test (moved to CP)#537
moonming merged 2 commits into
mainfrom
chore/retire-dp-sls-smoke

Conversation

@moonming

@moonming moonming commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

What

Removes the DP-side real-Aliyun-SLS smoke test (mod smoke in crates/aisix-obs/src/sink/sls.rssls_smoke_putlogs_and_readback + its readback/response_contains helpers) and its aliyun sls smoke (real) CI job.

Why

The real-credential SLS validation has moved to the control plane (api7/AISIX-Cloud#709) as a full-chain e2e: configure an aliyun_sls exporter via cp-api → boot a live DP → fire a real chat → read the request-event back from the real logstore. That exercises the actual user path (dashboard/cp-api config → kine → DP → upstream → SLS), which a DP-isolated smoke test cannot. The CP is where the whole feature integrates, so it's the right home for the real-credential check.

The org's SLS CI secrets (ALI_SLS_AK_ID / ALI_SLS_SK) have already been migrated from this repo to the CP.

Scope / safety

  • Pure deletion: 2 files, 205 lines, all removals. No production code touched.
  • The removed module was #[cfg(test)] and #[ignore]-gated — it never ran in the normal suite. Its helpers (readback, response_contains, env) were used only within it.
  • cargo clippy -p aisix-obs --all-targets -- -D warnings is clean — the production helpers the smoke test referenced (base_url_for, now_unix_secs, AliyunSlsSink) remain used by the sink + the regular unit tests, so nothing is orphaned.
  • Nothing needs: the removed CI job.
  • The DP's mock-SLS L2 e2e (sink mechanics: v1 signature / lz4 block / protobuf wire, against the in-stack mock-sls) is unaffected and remains the DP-side coverage.

Refs: #528, #532, api7/AISIX-Cloud#708, api7/AISIX-Cloud#709

Summary by CodeRabbit

  • Tests
    • Removed Aliyun SLS integration smoke tests from the CI pipeline and repository.
    • Updated e2e test documentation to clarify that live endpoint validation is handled by the control-plane full-chain e2e, not this repo.

The real-credential Aliyun SLS validation now lives on the control plane
(api7/AISIX-Cloud) as a full-chain e2e: configure an aliyun_sls exporter
via cp-api → boot a live DP → fire a real chat → read the request-event
back from the real logstore. That exercises the whole user path
(dashboard/cp-api config → kine → DP → upstream → SLS), which the
DP-isolated smoke could not.

Removes the now-dead `mod smoke` (sls_smoke_putlogs_and_readback +
readback/response_contains helpers) and its `aliyun sls smoke (real)` CI
job. The SLS secrets have already been migrated from this repo's CI to the
CP's. The DP's mock-SLS L2 e2e (sink mechanics: v1 signature / lz4 block /
protobuf wire) is unaffected and remains the DP-side coverage.

Refs: #528, #532, api7/AISIX-Cloud#708
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: e964faf9-5c0b-4883-93b5-68d0c510d428

📥 Commits

Reviewing files that changed from the base of the PR and between a575508 and ef5e0c4.

📒 Files selected for processing (1)
  • tests/e2e/src/cases/aliyun-sls-exporter-e2e.test.ts
✅ Files skipped from review due to trivial changes (1)
  • tests/e2e/src/cases/aliyun-sls-exporter-e2e.test.ts

📝 Walkthrough

Walkthrough

Removed the sls-smoke CI job and the corresponding #[cfg(test)] mod smoke in the SLS sink; updated the Aliyun SLS e2e test comment to state real endpoint acceptance is validated by the control-plane full-chain e2e.

Changes

SLS Smoke Test Removal

Layer / File(s) Summary
Remove SLS smoke test infrastructure
.github/workflows/ci.yml, crates/aisix-obs/src/sink/sls.rs, tests/e2e/src/cases/aliyun-sls-exporter-e2e.test.ts
Deleted the sls-smoke CI job (real SLS PutLogs smoke test), removed the #[cfg(test)] mod smoke integration test module that performed real Aliyun SLS PutLogs and readback, and extended the e2e test comment to point real-endpoint validation to the control-plane full-chain e2e.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

Audit LOW: the mock-SLS exporter e2e's header referenced the real-SLS
smoke this PR removes; point it at the control-plane full-chain e2e
instead.
@moonming
moonming merged commit 0d476c6 into main Jun 8, 2026
8 checks passed
@moonming
moonming deleted the chore/retire-dp-sls-smoke branch June 8, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant