test(e2e): fix propagation race in status-config resource-count asserts#797
Merged
Conversation
… synced 'synced' flips on an early revision before all three seeded resources are applied, so the eager count asserts raced propagation and failed with 'expected undefined to be 1' on a loaded runner (seen on the main CI run for 7295ff9). Fold the counts into the wait condition; the asserts below keep pinning the values. Same class as #795.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe status-config end-to-end test now waits for synchronized state and applied counts of one model, provider key, and API key before running assertions. ChangesStatus config synchronization
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's CI run for 7295ff9 failed
status-config-e2e > clean config reports synced with revisions and resource countswithexpected undefined to be 1: the test waits only forstate === "synced", but synced flips on an early revision before all three seeded resources are applied — the count asserts then race propagation on a loaded runner.Fold the resource counts into the
waitConfigPropagationcondition (the asserts below keep pinning the exact values). Same class as #795's fix; verified locally (file's 7 tests pass).Summary by CodeRabbit