This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Clone parameter to prevent duplicate instance in tree #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
commented
May 16, 2019
| return testParseFixture(file); | ||
| }); | ||
|
|
||
| it('handles multiple references to same parameter', () => { |
Member
Author
There was a problem hiding this comment.
Using an integration test because this particular bug is with interplay of using parameters referenced from multiple different components with element freeze(). There's a lot of setup state for this and it's simpler to test referencing in this way.
kylef
force-pushed
the
kylef/fix-multiple-ref-params
branch
2 times, most recently
from
ad72329 to
4b16fd6
Compare
Member
Author
|
I've also added similiar tests to ensure that all similiar referencing behaves correctly too. |
honzajavorek
approved these changes
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not place the exact same instance of a a referenced element in a final parse result tree multiple times, otherwise
.freeze()won't work. Final ParseResult should contain unique instances in all cases and thus we must clone an element in these cases.Fixes apiaryio/dredd#1360