This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Removes string parameter validation and number coercion#113
Closed
ecordell wants to merge 2 commits intoapiaryio:masterfrom
Closed
Removes string parameter validation and number coercion#113ecordell wants to merge 2 commits intoapiaryio:masterfrom
ecordell wants to merge 2 commits intoapiaryio:masterfrom
Conversation
Contributor
|
Fixed here: #114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to #111 - I just can't see any reason why the parser should assume that a parameter declared as a string and passed in as a string should try to convert it to a number and throw an error if it succeeds.
Figured I'd go ahead and remove it so that, if you agree with #111, there's no additional work to do. (Though I'd appreciate a version bump when/if this is merged)