This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Keep forward slashes in URL if they're present #258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apiaryio#93 Adds micro-dependency (url-join)
coagulant
force-pushed
the
feafure/fix-93-forward-slashes
branch
from
aa35ae7 to
dce9709
Compare
Contributor
|
@coagulant I'm sorry we didn't get to this for so long 😥 Do you think you could try to rebase this against current master and revisit this PR? |
Author
|
@honzajavorek sorry, but no, not using dredd anymore |
Contributor
|
@coagulant OK, thanks for letting me know! I'll try to use your code anyway if applicable, thanks very much for the contribution! |
3 tasks
Contributor
|
Closing this, replaced by #662 and released in v2.2.4. @coagulant Thank you for contributing, even though this PR didn't make it to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Adds micro-dependency (url-join)