This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Quick fix for the reporters issue #263 #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-vi
force-pushed
the
wvi/reporter-issue-quick-fix
branch
2 times, most recently
from
c3044da to
5210173
Compare
This really is more of a workaround rather then proper fix. Dredd needs to refactor and rework of the language hooks handling, especially graceful stopping as `SIGKILL` is definitely not the way to go.
w-vi
force-pushed
the
wvi/reporter-issue-quick-fix
branch
from
5210173 to
174acf2
Compare
kuba-kubula
added a commit
that referenced
this pull request
Aug 21, 2015
Quick fix for the reporters issue #263
artem-zakharchenko
pushed a commit
that referenced
this pull request
Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This really is more of a workaround rather than proper fix. Dredd needs
to refactor and rework of the language hooks handling, especially
graceful stopping as
SIGKILLis definitely not the way to go.