This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Hotfix of setCommandAndCheckForExecutables#406
Merged
Conversation
Method setCommandAndCheckForExecutables was stubbed in tests and was never executed, although in real world it is executed every time someone uses hooks. Since for different hook languages different parts of the method are summoned, it was easy for many if/else branches to slip through error/trials or tests. Due to this it was possible that it contained a lot of typos and errors, such as callbacks being never called or missing 'this'.
netmilk
pushed a commit
that referenced
this pull request
Mar 9, 2016
…ndAndCheckForExecutables Hotfix of setCommandAndCheckForExecutables
honzajavorek
deleted the
honzajavorek/hotfix-of-setCommandAndCheckForExecutables
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method setCommandAndCheckForExecutables was stubbed in tests and was never executed, although in real world it is executed every time someone uses hooks. Since for different hook languages different parts of the method are summoned, it was easy for many if/else branches to slip through error/trials or tests.
Due to this it was possible that it contained a lot of typos and errors, such as callbacks being never called or missing 'this'.
I believe this fixes #404, fixes #393 and possibly it could be also a solution for #384, but so far I can't be sure yet.