This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Merged
Conversation
Contributor
Author
|
I removed all stuck event loop workarounds and performed 250 iterations with |
Contributor
|
That's a good plan imho. Thanks! |
Contributor
Author
|
@netmilk 🎩👌 BTW, since the original PR was already reviewed, I consider this to be OK to merge when tests pass. If anyone thinks otherwise, write a comment now 😼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #331. I didn't want to work with @netmilk's branch directly as there was pretty nasty rebase needed and I was afraid to force-push and overwrite the original changes.
Closes #331, closes #289.