cli: fix live reload when indexer errors

[jaipaljadeja]

in dev mode, when there was an error in indexers, making changes would trigger reload but indexer wouldn't restart again, this fixes it.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces a new JSON file containing metadata for a prerelease version of the "apibara" package. The metadata specifies the release type as "prerelease," includes a comment regarding a live reload fix when indexer errors occur, provides the package name, and lists the author's email. Additionally, a modification in the CLI command script ensures that the reference to a child process is cleared (set to undefined) upon its close event.

Changes

File(s)	Change Summary
change/apibara-935efd34-b737-4496-a67f-450a4f7caa7f.json	Added a new JSON file with prerelease metadata for the "apibara" package, including a live reload fix comment and a dependent patch specification.
packages/cli/src/cli/commands/dev.ts	Updated the childProcess close event handler to set the childProcess variable to undefined after the process closes, ensuring improved state management.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as CLI Command
    participant CP as Child Process
    CLI->>CP: Spawn child process
    CP-->>CLI: Emits "close" event on exit
    CLI->>CLI: Handle "close" event by setting childProcess = undefined

Loading

Possibly related PRs

• cli: add instrumentation for side effects #158: Introduces a JSON file with prerelease type information for the "apibara" package.
• cli: include runtime-meta in package #114: Adds similar JSON metadata for prerelease versions, aligning with the structure seen in this PR.
• Fix build if indexer has no exports #151: Adds a JSON metadata file for a prerelease version of the package, correlating with the changes introduced here.

Suggested reviewers

• fracek

Poem

I'm a rabbit on a code-filled spree,
Hopping through changes as light as can be!
A JSON of magic, prerelease in hand,
Clearing child processes, oh so grand.
With each line of code, my heart does cheer,
A fresh new start — let’s hop into the year!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28d0444 and 8e743f4.

📒 Files selected for processing (2)

• change/apibara-935efd34-b737-4496-a67f-450a4f7caa7f.json (1 hunks)
• packages/cli/src/cli/commands/dev.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: test

🔇 Additional comments (2)

change/apibara-935efd34-b737-4496-a67f-450a4f7caa7f.json (1)

1-7: Changelog metadata looks correct.

The file properly documents the fix with appropriate information - the type is set as "prerelease", with a clear comment explaining the purpose of the change, and correctly specifies "patch" as the dependent change type.

packages/cli/src/cli/commands/dev.ts (1)

140-142: Good fix for the live reload issue.

Setting childProcess = undefined when the process closes is essential to ensure proper restarting of indexers after errors. Previously, if an indexer crashed with an error, the reference would still exist even though the process was dead, preventing restart on subsequent reload attempts.

This change is consistent with the same pattern applied in other sections of the code (lines 107 and 115), ensuring proper cleanup across all code paths.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.