-
Notifications
You must be signed in to change notification settings - Fork 11
cli: include runtime-meta in package #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughA new JSON file has been added to the project, providing metadata for the "apibara" package, including release type, comments, package name, author's email, and dependent change type. Additionally, the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/cli/package.json (1)
58-59: Consider moving runtime-meta files to the dist directoryThe new runtime-meta files are placed in the package root, while other compiled files are under the
dist/directory. This inconsistency might make maintenance more difficult.Consider:
- Moving these files to
dist/runtime/to maintain consistency- Updating the exports paths accordingly
"files": [ "dist", "src", - "runtime-meta.d.ts", - "runtime-meta.mjs", "README.md" ],And update the exports:
"./runtime/meta": { - "types": "./runtime-meta.d.ts", - "import": "./runtime-meta.mjs" + "types": "./dist/runtime/meta.d.ts", + "import": "./dist/runtime/meta.mjs" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
change/apibara-d2c0b8ca-2e3d-4189-91ea-3643281a08a2.json(1 hunks)packages/cli/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- change/apibara-d2c0b8ca-2e3d-4189-91ea-3643281a08a2.json
🔇 Additional comments (2)
packages/cli/package.json (2)
Line range hint 1-108: LGTM! The changes align with the PR objectives
The package.json changes successfully implement the runtime-meta inclusion with proper type definitions and module exports. The version bump to 2.0.0-beta.14 is appropriate for these changes.
Line range hint 46-56: Review the overlapping wildcard exports configuration
The wildcard exports ./runtime/* and ./dist/runtime/* both resolve to the same destination paths, which could lead to ambiguous module resolution. Consider:
- Keeping only one wildcard pattern
- Ensuring clear precedence rules if both patterns are necessary
Let's verify if there are any actual runtime files that would be affected by this:
No description provided.