Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@tommy87
Copy link
Contributor

@tommy87 tommy87 commented May 18, 2020

Enabled the use of an apiUse block in an apiDefine block

see issue apidoc/apidoc#859

@tommy87 tommy87 changed the base branch from master to dev May 18, 2020 14:34
@@ -0,0 +1 @@
registry=https://registry.npmjs.org
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we see this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use an own registry and when i do an simple npm publish it will be published to my registry and not not npmjs.org.
So we better specify it in .npmrc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have cloned the master branch, make my changes and then maked a pull request for the dev branch. If this was wrong i can change it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rottmann Yes I know, the question was why does it appear in the PR.

@tommy87 yes that is the issue.

@tommy87
Copy link
Contributor Author

tommy87 commented May 19, 2020

There is a little problem with ordering in the apuUse, so that in some cases elements are skipped. I will close this pull request and reopen it, when i have fixed

@tommy87 tommy87 closed this May 19, 2020
@tommy87
Copy link
Contributor Author

tommy87 commented May 19, 2020

The second commit prevent the deleting of the array while iterating and manipulating it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants