enable the use of an apiUse block in an apiDefine block #99
Conversation
| var name = definition.name; | ||
| var version = block.version || packageInfos.defaultVersion; | ||
| // remove unneeded target before starting the loop, to allow a save insertion of new elements | ||
| // TODO: create a cleanup filter |
There was a problem hiding this comment.
could you expand on that? It's not great to add a TODO ;)
There was a problem hiding this comment.
This is not from me. I only moved the ToDo and the delete upwards. Before my change both were located in the foreach loop at line 127
There was a problem hiding this comment.
In the connected ticket you can see the changes i made in a better overview. Githubs pull request didnt resolve the extra space i add for the new while loop
NicolasCARPi
left a comment
NicolasCARPi
left a comment
There was a problem hiding this comment.
I'll add a .editorconfig...
|
@NicolasCARPi |
|
I'm sorry if it takes a bit of time for PRs to be merged but I need to test them first. Speaking of tests, it would be great if you could add some test for that new feature in the test suite! |
|
I can add some tests, this shoulnd be a problem. But you need to tell me where i can add the test. |
|
In the |
|
@NicolasCARPi I think it would also be an big improvement for the project, if you can enable continous integration, which just run the "test" script |
|
@NicolasCARPi still waiting for the merge If you need help with this project, i could also help as a reviewer/maintainer. At least we want to use this tool more often in our company and i really waiting for the current merge, do enable auto generation of the documentation in our CI |
| ] | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
this line has whitespaces (we should really have an automatic tool to look/fix these minor issues...)
|
Hello @tommy87, you did well to remind me. Your code has been merged (sorry for the delay). I'll publish a new version soon. Ping me if not. |
Your help would be very welcome. See with @rottmann if he's willing to give you some permissions. Even without that, please feel free to review existing PRs/issues and comment on them. |
Ping ;) |
|
@rottmann if you want you can add me to the list of reviewers. So i can help you a little bit |
|
@tommy Welcome on board, i give you for the start "triage" rights, so you can manage issues and pull requests. Please coordinage with Nicolas, he is the "head of the department". @NicolasCARPi Upraded you rights to maintainer. So you can manage more settings in repositories. |
3 participants
Enabled the use of an apiUse block in an apiDefine block
see issue apidoc/apidoc#859
Note:
I have moved my changes to my dev branch and create a new pull request to apply only my changes. The old request was #96