Conversation
l2ysho
added
adhoc
DaveHanns
reviewed
Jul 9, 2026
Comment on lines
+57
to
+59
| const response = await axios.get<string>(manifest.localReadmeSuffixUrl!, { responseType: 'text' }); | ||
|
|
||
| await appendFile(readmePath, `\n\n${response.data}`); |
Contributor
There was a problem hiding this comment.
Q: why? Seems unrelated 🤔
Contributor
Author
There was a problem hiding this comment.
just to keep it the same as before -> readmeStream.write('\n\n');
vladfrangu
reviewed
Jul 9, 2026
vladfrangu
left a comment
vladfrangu
left a comment
Member
There was a problem hiding this comment.
Looks fine, let's maybe put in a special user agent when downloading a zip archive so its clear Apify cli is downloading
vladfrangu
approved these changes
Jul 9, 2026
DaveHanns
reviewed
Jul 9, 2026
Comment on lines
+701
to
+705
| export const downloadZip = async (url: string) => { | ||
| const response = await axios.get(url, { responseType: 'arraybuffer', validateStatus: () => true }); | ||
|
|
||
| if (response.status < 200 || response.status >= 300) { | ||
| throw new Error(`Failed to download the archive from ${url} (HTTP ${response.status}).`); |
Contributor
There was a problem hiding this comment.
Nit: we might want to print the error message as well, possibly 🤔
Suggested change
| export const downloadZip = async (url: string) => { | |
| const response = await axios.get(url, { responseType: 'arraybuffer', validateStatus: () => true }); | |
| if (response.status < 200 || response.status >= 300) { | |
| throw new Error(`Failed to download the archive from ${url} (HTTP ${response.status}).`); | |
| export const downloadZip = async (url: string) => { | |
| const response = await axios.get(url, { responseType: 'arraybuffer', validateStatus: () => true }); | |
| if (response.status < 200 || response.status >= 300) { | |
| const body = Buffer.from(response.data).toString('utf8').trim().slice(0, 500); | |
| throw new Error(`Failed to download the archive from ${url} (HTTP ${response.status}).`); |
DaveHanns
approved these changes
Jul 9, 2026
DaveHanns
left a comment
DaveHanns
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀 Some comments, nits, ...
l2ysho
deleted the
1271-apify-create-fails-with-adm-zip-invalid-or-unsupported-zip-format-on-blockedintercepted-networks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1271