refactor!: type RequestQueueClient's remaining raw-JsonObject methods - #9
Merged
Conversation
ListAndLockHeadAsync, ProlongRequestLockAsync, UnlockRequestsAsync, ListRequestsAsync and BatchDeleteRequestsAsync returned/took raw JsonObject instead of a typed model, unlike every other method on this client. Adds LockedRequestQueueHead, RequestLockInfo, UnlockRequestsResult, RequestQueueRequestsPage and BatchDeleteResult, following the OpenAPI-documented response schemas. Breaking change; ClientVersion bumped 0.2.0 -> 0.3.0. Co-authored-by: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
t-tooling
…estQueueHead Review found the new LockedRequestQueueHead model dropped queueModifiedAt (required by the OpenAPI schema and exposed by the reference JS client). The pre-existing RequestQueueHead had the same gap; fixed both for consistency. Also applies the reviewer's non-blocking ToPayload capacity-hint note. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal consistency cleanup found while auditing the client for improvement opportunities. Mirrors the same class of fix applied to the sibling Rust client on this identical resource.
What changed
RequestQueueClient's five remaining methods that used raw JSON, against the OpenAPI-documented response schemas:ListAndLockHeadAsync,ProlongRequestLockAsync,UnlockRequestsAsync,ListRequestsAsyncpreviously returned a rawJsonObjectBatchDeleteRequestsAsyncpreviously took an untypedobjectand returned a rawJsonObjectLockedRequestQueueHead,RequestLockInfo,UnlockRequestsResult,RequestQueueRequestsPage,BatchDeleteResultqueueModifiedAtfield toLockedRequestQueueHeadand the pre-existingRequestQueueHeadCompatibility
ClientVersionbumped0.2.0→0.3.0; seeCHANGELOG.mdfor the full list