fix(academy): avoid the Christmas tree - #2838
Merged
Merged
Conversation
At this stage of the course, students are not yet introduced to data cleaning, so I'd rather not put .replace() in their way. Choosing a slightly different category on the IKEA website avoids the Christmas tree, which means the price is just a three-digit number, which can be scraped as-is. This is a follow-up to the hotfix introduced in #2536
honzajavorek
added
the
t-academy
Contributor
|
🗑️ Preview for this PR was deleted. |
honzajavorek
marked this pull request as ready for review
July 31, 2026 14:24
szaganek
approved these changes
Aug 3, 2026
szaganek
left a comment
szaganek
left a comment
Contributor
There was a problem hiding this comment.
PR description on point, as always 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this stage of the course, students are not yet introduced to data cleaning, so I'd rather not put .replace() in their way. Choosing a slightly different category on the IKEA website avoids the Christmas tree, which means the price is just a three-digit number, which can be scraped as-is.
This is a follow-up to the hotfix introduced in #2536
I never thought I'd find myself in a phase of life where I'm creating a git branch called "avoid christmas tree", but 2026 is exactly this eventful and here we are...