refactor: unify build orchestration flows and fix runBuilds dry-run output - #126
Merged
Conversation
metalwarrior665
requested changes
Aug 22, 2026
metalwarrior665
left a comment
metalwarrior665
left a comment
Member
There was a problem hiding this comment.
I think it is for the better but few small notes
| }; | ||
|
|
||
| // Fixed version number used to build from local source files, since there is no real version to track. | ||
| export const ZIP_VERSION = '0.98'; |
Member
There was a problem hiding this comment.
Suggested change
| export const ZIP_VERSION = '0.98'; | |
| export const LOCAL_SOURCE_VERSION_NUM = '0.98'; |
|
|
||
| // Fixed version number used to build from local source files, since there is no real version to track. | ||
| export const ZIP_VERSION = '0.98'; | ||
|
|
Member
There was a problem hiding this comment.
Since we are hoisting the version here, I would also move the 0.99 as TESTING_VERSION_NUM
| ' same as the folder in the repository.', | ||
| ); | ||
| } | ||
| startActorBuild = async ({ |
Member
There was a problem hiding this comment.
There are so many similarly named functions which is really hard ot read, I would prefer to inline this and startActorBuildFromSourceFiles. It really just creates the version object and calls createVersionAndBuild. I think it would be cleaner that way.
metalwarrior665
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startActorBuild/startActorBuildFromLocalandrunBuilds/runBuildsFromLocalBuildData(this can maybe be expanded by adding additional debug logs)ts-ignoreinherited by oldapify-clientversion