chore: apply PR suggestions - #3589
Merged
Merged
Conversation
- use `Array.find` for use-until-failure - use `_getRandomIndex` for random strategy (no reservoir sampling) - only return undefined when the picked session is unusable, letting round-robin keep cycling through remaining usable sessions instead of degenerating into always creating a new one after any retirement https://claude.ai/code/session_01S3n74bCddQXdtqWFgoSiJ7
barjin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified and optimized the session selection logic in
SessionPool.getSession()by consolidating duplicate code paths and improving the random selection algorithm.Key Changes
Array.find()for cleaner code_getRandomIndex()method call, reducing algorithmic complexitygetSession()50 times instead of once to better validate session reuse behavior under repeated access patternsImplementation Details
The refactoring maintains the same external behavior while reducing code duplication. The key insight is that for round-robin and random strategies, we can select a session first and then check its usability, rather than iterating through all sessions to find a usable one. This simplifies the logic and makes the code more maintainable.
https://claude.ai/code/session_01S3n74bCddQXdtqWFgoSiJ7