refactor!: Move status message handling from StorageClient to the event system#3818
Merged
Conversation
janbuchar
added
the
t-tooling
barjin
reviewed
Jul 3, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
I'm curious what this means for the flaky message delivery as seen, e.g., in #3733
Anyway, lgtm nonetheless. Thanks @janbuchar !
barjin
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setStatusMessagefrom theStorageClientand handle it using the event system #3077setStatusMessageis no longer part of theStorageClientinterfaceBasicCrawleremits an event whenever it wants to change itcrawlerIdso that the consumer can aggregate messages from multiple crawlers