Skip to content

fix: remove outdated proxy package workaround #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VojtaM39 merged 1 commit into from
Sep 1, 2026
Merged

fix: remove outdated proxy package workaround #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions test/e2e/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,16 +292,6 @@ const createTestSuite = ({
upstreamProxyPort = takePort(freePorts);
upstreamProxyServer = createProxy(upstreamProxyHttpServer);
listenOnPort(upstreamProxyServer, upstreamProxyPort).then(() => resolve(), reject);

// This is a workaround to a buggy implementation of "proxy" package. On Node 10+,
// the socket sometimes emits ECONNRESET error, which would break the test.
// We just swallow it.
upstreamProxyServer.on('connect', (_req: http.IncomingMessage, socket: net.Socket) => {
socket.on('error', (err: NodeJS.ErrnoException) => {
if (err.code === 'ECONNRESET') return;
throw err;
});
});
});
}
}).then(async () => {
Expand Down
Loading