feat: add batch create/update/delete item contracts - #37
Open
shalk wants to merge 1 commit into
Open
Conversation
…ontracts Expose three new Item Management operations for submitting a list of namespace items to create, update, or delete in one call: - POST .../items/batch-create (batchCreateItems) - PUT .../items/batch-update (batchUpdateItems) - POST .../items/batch-delete (batchDeleteItems) Bump version to 0.3.11.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 28, 2026
nobodyiam
requested changes
Aug 29, 2026
nobodyiam
left a comment
Member
There was a problem hiding this comment.
The three batch paths and generated Spring signatures align with the companion implementation, and the local contract and generation checks pass. One contract mismatch remains.
Please fix this blocking item before updating:
- In
apollo-openapi.yaml, express the runtime batch validation in the contract: addminItems: 1to all three request arrays, addminLength: 1to the batch-delete key items, and document400withExceptionResponseforbatchDeleteItems. Please extendtests/test_item_batch_contract.pyaccordingly. The companion controller rejects these inputs with HTTP 400, so v0.3.11 should not advertise them as valid or leave that response undocumented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST .../items/batch-create(batchCreateItems)PUT .../items/batch-update(batchUpdateItems)POST .../items/batch-delete(batchDeleteItems)Motivation
Apollo's OpenAPI item endpoints only support single-item create/update/delete (plus namespace-text replace and cross-namespace sync/diff). There's no operation for submitting a structured batch of creates/updates/deletes against a single namespace. This is a companion PR to a corresponding
apolloconfig/apollochange that implements these operations against the existing internalItemChangeSetsbatch plumbing.Test plan
./generate.sh --verifypython -m unittest tests/test_item_batch_contract.py🤖 Generated with Claude Code