Skip to content

Conversation

@phryneas
Copy link
Member

@phryneas phryneas commented May 14, 2025

This backports the big new test from #12556 so we can see what the changes in behaviour in the two braches are.

Look at commit 6c7d562 (#12620) here.

New behaviour on the left, old behaviour on the right.

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 093fde8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 14, 2025

npm i https://pkg.pr.new/@apollo/client@12620

commit: 1e3c06c

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

size-limit report 📦

Path Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 41.94 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 37.49 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 32.3 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 27.21 KB (0%)
import { ApolloProvider } from "@apollo/client/react" 5.19 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production) 963 B (0%)
import { useQuery } from "@apollo/client/react" 10.38 KB (0%)
import { useQuery } from "@apollo/client/react" (production) 6.13 KB (0%)
import { useLazyQuery } from "@apollo/client/react" 6.35 KB (0%)
import { useLazyQuery } from "@apollo/client/react" (production) 2.12 KB (0%)
import { useMutation } from "@apollo/client/react" 5.73 KB (0%)
import { useMutation } from "@apollo/client/react" (production) 1.48 KB (0%)
import { useSubscription } from "@apollo/client/react" 6.08 KB (0%)
import { useSubscription } from "@apollo/client/react" (production) 1.83 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" 7.81 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production) 3.58 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" 7.64 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production) 3.41 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" 7.63 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production) 3.39 KB (0%)
import { useReadQuery } from "@apollo/client/react" 5.86 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production) 1.61 KB (0%)
import { useFragment } from "@apollo/client/react" 5.91 KB (0%)
import { useFragment } from "@apollo/client/react" (production) 1.68 KB (0%)

@phryneas phryneas force-pushed the pr/compare-behaviour branch from 7d89892 to b57941c Compare May 14, 2025 12:27
@phryneas
Copy link
Member Author

We decided off-channel that it makes sense to actually merge this one, so I'll give it a merge :)

@phryneas phryneas changed the title [do not merge] compare loading/emit changes in 12556 refactpr test for loading/emit changes May 14, 2025
@phryneas phryneas changed the title refactpr test for loading/emit changes refactpr test for loading/emit changes and nextFetchPolicy May 14, 2025
@github-actions github-actions bot added the auto-cleanup 🤖 label May 14, 2025
@phryneas phryneas merged commit 0a99d9c into release-4.0 May 15, 2025
32 of 33 checks passed
@phryneas phryneas deleted the pr/compare-behaviour branch May 15, 2025 07:48
@phryneas phryneas changed the title refactpr test for loading/emit changes and nextFetchPolicy refactor test for loading/emit changes and nextFetchPolicy May 15, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants