Skip to content

Conversation

@joselsegura
Copy link
Contributor

Adding some definitions to make the built image FIPS enabled.

@openshift-ci openshift-ci bot requested review from JoaoFula and tremes November 21, 2024 11:30
@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2024

Hi @joselsegura. Thanks for your PR.

I'm waiting for a app-sre member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ncaak
Copy link
Contributor

ncaak commented Nov 21, 2024

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (9b7ed13) to head (1dfbb66).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           
---- 🚨 Try these New Features:

@ncaak
Copy link
Contributor

ncaak commented Nov 22, 2024

/lgtm

@ncaak
Copy link
Contributor

ncaak commented Nov 25, 2024

/ok-to-test

@ncaak
Copy link
Contributor

ncaak commented Nov 25, 2024

/lgtm cancel
merging this after #388

@openshift-ci openshift-ci bot removed the lgtm label Nov 25, 2024
@tremes
Copy link
Contributor

tremes commented Nov 25, 2024

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joselsegura, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor

tremes commented Nov 25, 2024

/approved

@ncaak
Copy link
Contributor

ncaak commented Nov 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f170335 into app-sre:master Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants