-
Notifications
You must be signed in to change notification settings - Fork 49
Adding the option to build the image with FIPS compatibility #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @joselsegura. Thanks for your PR. I'm waiting for a app-sre member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 46.16% 46.16%
=======================================
Files 22 22
Lines 1083 1083
=======================================
Hits 500 500
Misses 553 553
Partials 30 30
|
|
/lgtm |
|
/ok-to-test |
|
/lgtm cancel |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joselsegura, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/approved |
|
/lgtm |
Adding some definitions to make the built image FIPS enabled.