Skip to content

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Nov 22, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (b2bd7e7) to head (df6241a).
Report is 7 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           
---- 🚨 Try these New Features:

@tremes
Copy link
Contributor Author

tremes commented Nov 25, 2024

it probably requires some update
/hold

@tremes
Copy link
Contributor Author

tremes commented Nov 25, 2024

/unhold

@tremes
Copy link
Contributor Author

tremes commented Nov 25, 2024

/test ci-index-dvo-operator-bundle

Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bbbe961 into app-sre:master Nov 25, 2024
9 checks passed
tremes added a commit to tremes/deployment-validation-operator that referenced this pull request Nov 26, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 26, 2024
* Revert "generate catalog Dockerfile dynamically (#390)"

This reverts commit 93075f4.

* Revert "Migrate to file based catalog (#388)"

This reverts commit bbbe961.
tremes added a commit to tremes/deployment-validation-operator that referenced this pull request Nov 27, 2024
* Migrate to file based catalog

* update

* add opm render command
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 27, 2024
* Migrate to file based catalog

* update

* add opm render command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants