fix: flush Android writes before emulator shutdown - #357
Open
janicduplessis wants to merge 1 commit into
Open
Conversation
janicduplessis
marked this pull request as ready for review
September 4, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
stim stopand the other centralized Android teardown paths kill a running emulator immediately. Guest writes made just before shutdown can be lost, including a freshly installed APK.Fixes #283
Solution
Flush the guest filesystem with
adb shell syncbeforeemu kill. A sync failure warns on stderr but does not block shutdown, preserving cleanup semantics. The helper is reached only after Stim re-resolves a running AVD as owned.Test plan
adb shell syncargument shape verified; persistence was not re-measured on a booted AVD because none was connected.