Skip to content

feat: runtime parity for handling both ElasticSearch 6 and 7 upstreams#51

Merged
siddharthlatest merged 148 commits intodevfrom
feat/runtime_es6_es7_parity
Dec 10, 2019
Merged

feat: runtime parity for handling both ElasticSearch 6 and 7 upstreams#51
siddharthlatest merged 148 commits intodevfrom
feat/runtime_es6_es7_parity

Conversation

@bietkul
Copy link
Copy Markdown

@bietkul bietkul commented Nov 27, 2019

What does this do / why do we need it?

This PR merges the Arc codebase (which was previously separate) for ElasticSearch v6 and ElasticSearch v7.

What should your reviewer look out for in this PR?

Everything - it's a major refactor.

Do you need help or clarification on anything?

Which issue(s) does this PR fix?

Comment thread util/esclient.go Outdated
Comment thread util/esclient.go Outdated
Comment thread plugins/auth/dao.go Outdated
Comment thread util/retrier.go Outdated
@bietkul bietkul changed the title feat: make logs plugin compatible with es6 feat: es6_es7 parity changes Dec 4, 2019
Comment thread util/esclient.go Outdated
Comment thread plugins/reindexer/service.go
Comment thread util/esclient.go Outdated
@siddharthlatest siddharthlatest changed the title feat: es6_es7 parity changes feat: runtime parity for handling both ElasticSearch 6 and 7 upstreams Dec 5, 2019
@bietkul
Copy link
Copy Markdown
Author

bietkul commented Dec 5, 2019

@siddharthlatest Fixed it.

Copy link
Copy Markdown
Member

@siddharthlatest siddharthlatest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants