fix: add authentication to public key routes#52
Merged
siddharthlatest merged 151 commits intodevfrom Dec 10, 2019
Merged
Conversation
feat: add billing
fix: size issue in Request Logs
fix: remove subscription_id
…ling * 'test/billing' of github.com:appbaseio/arc: fix: remove fmt.Println(..) log
…c into feat/runtime_es6_es7_parity
siddharthlatest
changed the base branch from
feat/runtime_es6_es7_parity
to
dev
siddharthlatest
changed the base branch from
dev
to
feat/runtime_es6_es7_parity
siddharthlatest
changed the base branch from
feat/runtime_es6_es7_parity
to
dev
siddharthlatest
changed the base branch from
dev
to
feat/runtime_es6_es7_parity
siddharthlatest
changed the base branch from
feat/runtime_es6_es7_parity
to
dev
siddharthlatest
changed the base branch from
dev
to
feat/runtime_es6_es7_parity
siddharthlatest
changed the base branch from
feat/runtime_es6_es7_parity
to
dev
siddharthlatest
approved these changes
Dec 10, 2019
Member
siddharthlatest
left a comment
siddharthlatest
left a comment
There was a problem hiding this comment.
tested, this works well (y)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Currently, the routes to set/get public keys are open i.e no authentication, this PR adds auth to those routes and categorizes them into a new category named
auth.What should your reviewer look out for in this PR?
Review the technical details, especially the category & auth logic.
Do you need help or clarification on anything?
Which issue(s) does this PR fix?