Adfa 4587 add GitHub logo for discussions

[Elissa-AppDevforAll]

• Fix About page displays Telegram logo for GH discussions
• Update the string name from R.string.telegram_group_url to refer to GH, not Telegram
• Change preference to open with GitHub app, not Telegram app
• Rename ACTION_TG_GROUP to ACTION_GH_FORUM because we’re not talking about a Telegram group

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ee00263-3bca-4c88-b623-61d4ac9b73b9

📥 Commits

Reviewing files that changed from the base of the PR and between 07e7890 and e046e04.

📒 Files selected for processing (1)

• app/src/main/java/com/itsaky/androidide/activities/AboutActivity.kt

🚧 Files skipped from review as they are similar to previous changes (1)

• app/src/main/java/com/itsaky/androidide/activities/AboutActivity.kt

---

📝 Walkthrough

• Updated the About page socials/discussion entry to use GitHub Discussions instead of Telegram (new ACTION_GH_FORUM action and github_discussions_url target URL).
• Replaced the Telegram-related icon with a new GitHub vector drawable (ic_github.xml) for the discussions entry.
• Added github_discussions_url and removed/replaced the previous Telegram URL resource (telegram_group_url).
• Risk / best-practice note: the About entry title resource argument still uses R.string.discussions_on_telegram (localized as “on Telegram”), so this may leave Telegram wording on the GitHub Discussions UI—verify the string/label is updated to a GitHub-appropriate text to avoid user-facing inconsistencies.

Walkthrough

AboutActivity's Telegram group social entry is replaced with a GitHub Discussions entry, including updated action handling, a GitHub icon drawable, and a replacement URL string. The existing title resource still references Telegram.

Changes

GitHub Discussions social link replacement

Layer / File(s)	Summary
GitHub Discussions action and resource wiring app/src/main/java/com/itsaky/androidide/activities/AboutActivity.kt, resources/src/main/res/drawable/ic_github.xml, resources/src/main/res/values/strings.xml	Adds ACTION_GH_FORUM, opens the GitHub Discussions URL, updates the social item icon and URL, adds the GitHub drawable, and replaces telegram_group_url with github_discussions_url. The item title remains discussions_on_telegram.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• appdevforall/CodeOnTheGo#1438: Updates related Telegram-group strings and GitHub Discussions URL wiring.

Suggested reviewers: hal-eisen-adfa, jatezzz, itsaky-adfa

Poem

A rabbit hops to GitHub's door,
Where lively discussions grow evermore.
A shining icon marks the way,
While Telegram's link hops away.
One small burrow, neatly spun—
Hop, hop, the update's done! 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: replacing the discussions Telegram logo with a GitHub logo.
Description check	✅ Passed	The description is clearly related to the About page and GitHub discussions updates in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-4587-Add-GitHub-logo-for-discussions

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

app/src/main/java/com/itsaky/androidide/activities/AboutActivity.kt (1)

148-151: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Stale Telegram-named string resource used for GitHub Discussions item.

R.string.discussions_on_telegram (defined in resources/src/main/res/values/strings.xml) is still used as the title for the new GitHub Discussions entry. The PR's stated goal is renaming Telegram-specific references to GitHub ones; this resource key was missed. Consider renaming the key (e.g., discussions_forum_title) to match the new context.

♻️ Suggested rename

-          R.string.discussions_on_telegram,
+          R.string.discussions_forum_title,

Corresponding change needed in strings.xml:

-	<string name="discussions_on_telegram">Support and discussions forum</string>
+	<string name="discussions_forum_title">Support and discussions forum</string>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/java/com/itsaky/androidide/activities/AboutActivity.kt` around
lines 148 - 151, The GitHub Discussions entry in AboutActivity still uses the
Telegram-specific string resource, so update the title reference to the renamed
forum resource. In AboutActivity’s item setup, replace the use of
R.string.discussions_on_telegram with the new neutral key, and make the matching
rename in strings.xml so the resource name reflects GitHub Discussions rather
than Telegram.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@app/src/main/java/com/itsaky/androidide/activities/AboutActivity.kt`:
- Around line 148-151: The GitHub Discussions entry in AboutActivity still uses
the Telegram-specific string resource, so update the title reference to the
renamed forum resource. In AboutActivity’s item setup, replace the use of
R.string.discussions_on_telegram with the new neutral key, and make the matching
rename in strings.xml so the resource name reflects GitHub Discussions rather
than Telegram.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2e3e12ea-26e2-4972-b6b8-4158c1c277b3

📥 Commits

Reviewing files that changed from the base of the PR and between db0137a and 07e7890.

📒 Files selected for processing (3)

• app/src/main/java/com/itsaky/androidide/activities/AboutActivity.kt
• resources/src/main/res/drawable/ic_github.xml
• resources/src/main/res/values/strings.xml