ADFA-4476: animate the module-management install button like the othe…#124
Merged
Merged
Conversation
…r action buttons The 'Launch install' button in Module management was a plain Button, so it lacked the indeterminate progress bar (the sweeping fill/empty bar at the bottom) that the fast-install / backup / restore buttons show while working. Make it a ProgressButton and drive it from the module-queue observer: start the animation on RUNNING, stop it on DONE. startProgress() is idempotent (guards on isRunning), so re-observing after a recreation does not restart it. - fragment_deploy.xml: btn_launch_install is now org.iiab.controller.ProgressButton. - DeployFragment / InstallController: field + constructor param typed ProgressButton (ProgressButton extends AppCompatButton, so existing calls are unchanged); drop the now-unused android.widget.Button import in InstallController. - renderModuleQueue: startProgress() on RUNNING, stopProgress() on DONE. Pure UI polish, no behaviour change to the install pipeline. Stacked on the slice-3 branch (ADFA-4476 modules-through-service) since the animation is driven by its renderModuleQueue observer.
luisguzman-adfa
force-pushed
the
feat/ADFA-4476-launch-button-progress
branch
from
8eebab0 to
143c6ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r action buttons
The 'Launch install' button in Module management was a plain Button, so it lacked the indeterminate progress bar (the sweeping fill/empty bar at the bottom) that the fast-install / backup / restore buttons show while working. Make it a ProgressButton and drive it from the module-queue observer: start the animation on RUNNING, stop it on DONE. startProgress() is idempotent (guards on isRunning), so re-observing after a recreation does not restart it.
Pure UI polish, no behaviour change to the install pipeline. Stacked on the slice-3 branch (ADFA-4476 modules-through-service) since the animation is driven by its renderModuleQueue observer.