feat(sync): carve arch-check into ArchCheckController (ADFA-4506 slic…#126
Merged
Merged
Conversation
…e 1) Strangler-fig carve of the SyncFragment god class (residual after the ADFA-4492 export). First, lowest-risk slice: the 32/64-bit architecture compatibility check. - New sync/presentation/ArchCheckController (+ ArchCheckHost seam), mirroring the ResetDeleteController/AdbShareController pattern: constructed with (fragment, host); borrows the two arch-label views via bind(). - Moves getArchBits/getTermuxArch, the incompatibility dialog, the compatibility-success feedback (vibrate + snackbar + delayed label reset, S8 lifecycle guards preserved verbatim), and label visibility out of SyncFragment. The mode/server state the visibility rule needs is read back through ArchCheckHost (isShareMode / isServerRunning). - SyncFragment implements ArchCheckHost; drops 3 now-unused imports. Behaviour-preserving. No new strings (no MissingTranslation impact). Next slices: ApkShare, ShareServer, Receive controllers.
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1/4 of the ADFA-4506 SyncFragment carve (residual after the ADFA-4492 export).
Extracts the 32/64-bit architecture compatibility check into a dedicated collaborator, mirroring the existing ResetDeleteController / AdbShareController seam:
Behaviour-preserving refactor. No new strings (no MissingTranslation impact); brace-balanced, no dangling refs, controller imports all used. Not compiled in-sandbox — please build (:app:lintDebug).
Refs ADFA-4506; epic ADFA-1028. Next slices: ApkShareController, ShareServerController, ReceiveController.