feat(ADFA-4579): standardize Snackbars on reading-time duration#145
Merged
Conversation
Add util/Snackbars.make(view, msg | resId), which applies SnackbarDuration.millisForText, and convert all 63 fixed Snackbar.make(..., LENGTH_SHORT/LONG) call sites across 11 files to it, so long messages are no longer truncated. Short confirmations clamp to MIN_MS (3s) per the single-rule decision. Pre-existing explicit-duration calls (BackupController millisForText, the 6000ms server-not-installed snackbar) are left as-is. Follow-ups (tracked in ADFA-4579): a Toast equivalent, and a custom lint rule flagging Snackbar.LENGTH_* for build-time enforcement.
luisguzman-adfa
force-pushed
the
feat/ADFA-4579-snackbar-duration-sweep
branch
from
4e71ff3 to
2bf716f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add util/Snackbars.make(view, msg | resId), which applies SnackbarDuration.millisForText, and convert all 63 fixed Snackbar.make(..., LENGTH_SHORT/LONG) call sites across 11 files to it, so long messages are no longer truncated. Short confirmations clamp to MIN_MS (3s) per the single-rule decision. Pre-existing explicit-duration calls (BackupController millisForText, the 6000ms server-not-installed snackbar) are left as-is.
Follow-ups (tracked in ADFA-4579): a Toast equivalent, and a custom lint rule flagging Snackbar.LENGTH_* for build-time enforcement.