style(ADFA-4520): 'Show Wi-Fi QR' button — half-width, left, purple#147
Merged
Merged
Conversation
luisguzman-adfa
force-pushed
the
feat/ADFA-4520-lohs-qr-button-style
branch
from
efa65c1 to
65b7920
Compare
- 'Show Wi-Fi QR' button: half-width, left-aligned (under the toggle text) via a horizontal row + spacer, 44dp tall, bold, more saturated purple (@color/lohs_qr_purple #7B1FA2) since accent_secondary #6A3FB5 renders washed-out/lavender on OLED (rounded_button is white tinted by backgroundTint). - Recommendation snackbar (lohs_recommend): drop '(BETA)' (wasted space, truncated the message; the BETA marker stays as the toggle pill), and reference the localized menu name instead of the literal English 'Advanced settings' (es 'Configuración avanzada', fr 'Paramètres avancés', pt 'Configurações avançadas', hi 'उन्नत सेटिंग्स', ru 'Расширенные настройки') to match network_advanced_label per locale.
luisguzman-adfa
force-pushed
the
feat/ADFA-4520-lohs-qr-button-style
branch
from
65b7920 to
6b77e79
Compare
luisguzman-adfa
pushed a commit
that referenced
this pull request
Jul 7, 2026
… carve Rebased onto main after #147 (ADFA-4520). Final slice of F1. - New ServerController owns the native-server lifecycle (pdsm start/stop + fake /proc sysdata, the 3s status+connectivity poll, transition timeout, serverEngine, currentTargetUrl, Wi-Fi/hotspot flags) and publishes ServerState to the repository. - Host (MainActivity): addToLog, UsageFragment pulses, refreshServerUi, get/setTargetServerState, isNegotiating, and the shared watchdog toggle. The transition-UI state stays on MainActivity so UsageFragment is untouched. - MainActivity: removed the server fields + updateServerAlive/pingUrl/createFakeSysData/ checkServerStatus/updateConnectivityStatus; onCreate constructs + starts the controller; onResume/onPause forward; handleServerLaunchClick delegates; the CLI 'prepare rootfs' broadcast, the QR guard and isHotspotActive() call the controller. 1058 -> 813 LOC. - Picked up #147's util/Snackbars: MainActivity's remaining snackbars stay on Snackbars, and the moved termux-stuck-warning uses Snackbars in ServerController too. Behaviour-preserving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LOHS QR button was cramped (wrap_content). Make it half-width and left-aligned (under the 'Enable Hotspot LocalOnly' text) via a horizontal row with a spacer, 44dp tall, bold. Use a more saturated purple (@color/lohs_qr_purple #7B1FA2) because the previous accent_secondary #6A3FB5 reads washed-out/lavender on OLED (rounded_button is white tinted by backgroundTint).