ADFA-4630: provision resolv.conf at terminal login so the terminal has DNS#174
Merged
Merged
Conversation
…s DNS Entering the terminal (iiab --login) is not a boot, so nothing seeded /etc/resolv.conf and DNS/internet failed from the manual terminal -- only the app's install/start paths write it (via PRootEngine). do_login() now seeds resolv.conf from the app's effective DNS (PrefsDnsConfigRepository.loadEffective(): the user's custom config when enabled, else defaults) right before entering the jail, without starting any service. The --reset bootstrap now uses that same effective DNS instead of hardcoded 1.1.1.1/8.8.8.8. DNS values are charset-guarded (IPv4/IPv6 only) before being echoed into the generated CLI script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entering the terminal (
iiab --login) is not a "boot", so nothing seeded/etc/resolv.confand DNS/internet failed from the manual terminal. Only the app's install/start paths write it (viaPRootEngine).Change
TerminalController.do_login()now seeds/etc/resolv.conffrom the app's effective DNS (PrefsDnsConfigRepository.loadEffective()— the user's custom config when enabled, else defaults) right before entering the jail, without starting any service. Same source/behavior the app already uses on every proot launch.--resetbootstrap now uses that same effective DNS instead of hardcoded1.1.1.1/8.8.8.8.Verify
iiab --login(server stopped, no prior install this session), then inside:cat /etc/resolv.confshows the configured nameserver(s) and DNS resolves (e.g.getent hosts github.com/ a download works).resolv.confreflects it.Relates to ADFA-4629 (surfaced during its verification).