ADFA-4544: reach the tar diagnostic on a broken pipe (+ throttle log …#193
Merged
Merged
Conversation
…flood)
When tar died mid-stream, closing its stdin via try-with-resources re-threw
EPIPE on flush/close, which escaped to the outer catch as a bare 'Fatal
Extraction Error: EPIPE' and bypassed the rich diagnostic (tar exit code, last
tar output, disk space). Close tarInput defensively (swallow the close EPIPE)
and guard the happy-path flush, so waitFor() and the diagnostic always run.
Also throttle the per-file 'Tar Output' logcat line — it was flooding logcat
('over proc quota' drops) and could swallow tar's real error; the full tail is
still retained in memory for the surfaced diagnostic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes ADFA-4544's diagnostic. On a broken pipe (tar dies mid-extraction), closing/flushing tar's stdin re-threw EPIPE and escaped to the outer catch as a bare "Fatal Error: EPIPE", bypassing
waitFor()and the rich diagnostic (tar exit code, last tar output, free disk space).Changes (
TarExtractor.javaonly):waitFor()and the failure diagnostic always run.Diagnostic-only — no happy-path behaviour change. Makes a future extraction failure legible (e.g.
exit 137phantom-process kill, or ENOSPC) instead of an opaque EPIPE. Relates to ADFA-4496.