ADFA-4982: mark setup complete only on real install; resume the wizard instead of an empty Home - #319
Merged
Merged
Conversation
…d instead of an empty Home The wizard set pref_key_setup_complete when the user picked 'Internet download' (before any install), so bailing during edition/size selection stranded the user on an empty Home with no way back. - WizardActivity: the 'download' choice no longer marks complete; and a fresh, not-yet-complete launch with permissions already granted resumes at the setup choice (step 3) instead of re-running welcome/language/permissions. 'Copy from a phone' / 'Skip for now' stay deliberate. - SetupLibraryActivity.startWizardInstall: mark complete NOW (the real install start), which also keeps the install LibraryActivity from redirecting back to the wizard. - Step1 Back therefore routes through LibraryActivity (which, seeing !complete, returns to the wizard's setup choice) — resuming where the user was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wizard set pref_key_setup_complete when the user picked 'Internet download' (before any install), so bailing during edition/size selection stranded the user on an empty Home with no way back.