ADFA-5343 docs(server-lifecycle): add reconciler ADR + design-coherence guard - #496
Merged
Merged
Conversation
…ce guard Add ADR-5343 (proposed): a single process-scoped server-lifecycle reconciler to replace the scattered monitor/actuator split and the multiple liveness sources. Includes evidence, alternatives, collapse table, reduction scorecard, and a phased migration plan. Add a 'Design coherence' guard to CLAUDE.md capturing the anti-accretion rules the ADR motivates (prove a new state isn't a duplicate truth; one source per fact; N tickets on one concern is a redesign signal; the code-review second pass is a standing pre-merge gate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs-only. Adds ADR-5343 (status: Proposed) and a matching design-coherence
guard to the repo
CLAUDE.md.controller/docs/ADR-5343-server-lifecycle-reconciler.md— proposes a single,process-scoped server-lifecycle reconciler to replace the Activity-scoped
monitor/actuator split and the multiple liveness sources. Includes the evidence
(file:line), ≥2 alternatives, a collapse table (how current bugs/patches —
ADFA-5330, 5336, 5280, 4837, 5103 — are subsumed), a target state diagram with
fewer states, a reduction scorecard, and a phased, device-verifiable migration plan.
CLAUDE.md— new "Design coherence" section: the anti-accretion rules the ADRmotivates (prove a new state isn't a duplicate truth; one source per fact; N
tickets on one concern is a redesign signal; the code-review second pass is a
standing pre-merge gate).
.gitignore— ignoreCLAUDE.local.md(per-contributor local overrides).Why
The server-lifecycle model accreted ~17 tickets, each adding a state to compensate
for a missing always-on owner. This records the target design before any code, and
the guard makes the "don't patch a design gap with another flag" rule explicit.
Scope / verification
No production code, no APK change — the ADR is Proposed and gates its own
implementation. "Superseded" stamps on affected docs go on per migration phase, not
here. Nothing to verify on device.