feat/ADFA-3603 ndk plugin#2
Merged
Merged
Conversation
Daniel-ADFA
reviewed
Apr 24, 2026
| } | ||
|
|
||
| android { | ||
| namespace = "com.codeonthego.ndkinstaller" |
Collaborator
There was a problem hiding this comment.
@jomen-adfa please use org.appdevforal. for the package name
Contributor
Author
There was a problem hiding this comment.
changed package name to org.appdevforall
Comment on lines
+113
to
+114
| .description("An NDK and CMake binary installer with corresponding NDK Activity template") | ||
| .showPackageNameOption() |
Collaborator
There was a problem hiding this comment.
I see that the template.json file is unused, for the saveLocation parameter, you can use the default location
".defaultSaveLocation("")"
Contributor
Author
There was a problem hiding this comment.
It seems when saveLocation is omitted it appears as expected.
Contributor
There was a problem hiding this comment.
yes, this is the default fallback if none is provided
fryanpan
added a commit
that referenced
this pull request
May 11, 2026
…ff Main Three changes in one commit since they all touch the same fragment: - Bounded bitmap decode (#4): two-pass decode with inSampleSize keyed off display width. A full-resolution 2048x2048 PNG as ARGB_8888 is ~16 MB of native heap; on the team's 2-4 GB target devices, repeated decodes risk OOM. New decodeBitmapBounded helpers in the companion object, used by both the cold-start render and the fetch path. - Move cold-start render off Main (#5): renderFromCacheAsync replaces renderFromCache. JSON parse + PNG decode now happen on Dispatchers.IO via lifecycleScope; the showComic hop returns to Main. Removes a measurable jank window during fragment inflation. - Remove dead legendView field (#6): declared, assigned, nulled, never read. The legend text comes straight from the XML resource. Document the URI permission caveat on copyImageToClipboard (#2): ClipData.newUri does not auto-grant FLAG_GRANT_READ_URI_PERMISSION; we rely on the host FileProvider's grantUriPermissions=true and the system's clipboard-handler logic. Verified on real device per the test-case S4 gate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial commit for ndk plugin