Added gcm setting for phonegap compatibility mode #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Really great! Thanks! |
Owner
|
@alex-friedl there is a branch from your pull request that is not covered with tests. I would like to publish this new feature to npm, could you provide a test for the remaining branch? I've integrated with coveralls, so now you can run Thanks again for your effort! :) |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending notifications to Android applications that are built with Cordova and the PhoneGap PushPlugin, the background notification handler in the app is not called.
According to the documentation of the Push Plugin (https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#android-behaviour), they recommend sending only a
dataobject as payload.In this PR I added a flag that can be used to send GCM messages in the way recommended for the PhoneGap Push plugin