fix: do not trust XCUIElement.lastSnapshot for long-lived elements - #1235
Merged
Conversation
lastSnapshot can be a leftover from an unrelated earlier command (e.g. GET /source) when self is a long-lived element such as the tested application or an FBElementCache entry, silently hiding UI content that appeared since. Use fb_cachedSnapshot, which is backed by XCTest's own self-invalidating snapshot cache, in the class chain snapshot-walk strategy, descendant filtering, and XPath context scoping. Fixes appium/appium#22672 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
KazuCocoa
approved these changes
Aug 28, 2026
|
🎉 This PR is included in version 16.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lastSnapshot can be a leftover from an unrelated earlier command (e.g. GET /source) when self is a long-lived element such as the tested application or an FBElementCache entry, silently hiding UI content that appeared since. Use fb_cachedSnapshot, which is backed by XCTest's own self-invalidating snapshot cache, in the class chain snapshot-walk strategy, descendant filtering, and XPath context scoping.
Fixes appium/appium#22672