feat: Add fileFieldName default value of ScreenRecordingUploadOptions#1591
Closed
jaden-k wants to merge 1 commit into
Closed
feat: Add fileFieldName default value of ScreenRecordingUploadOptions#1591jaden-k wants to merge 1 commit into
jaden-k wants to merge 1 commit into
Conversation
|
|
| private Map<String, Object> formFields; | ||
|
|
||
| /** | ||
| * Creates new instance with default fileFieldName. |
Contributor
There was a problem hiding this comment.
the default value for this option is already set to file: https://github.com/appium/appium-support/blob/04416e36df6e1c43f8fd00da7747372b03abb3c5/lib/net.js#L33
Author
Contributor
There was a problem hiding this comment.
then it would make sense to change the way headers are set. I'll create a PR for it. You could anyway provide a value to withFileFieldName in order to workaround the issue with the existing implementation
Author
|
uncalled-for~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Added fileFieldName default value(file) of ScreenRecordingUploadOptions with some basic tests
Types of changes
Details
In v7.4.0 earlier versions,STOP_RECORDING_SCREEN command is not working since appium-server v1.21.0.
One of the ways to solve this problem is upgrading java-client and adding the fileFieldName option in test code.
It looks like being provided fileFieldName default value is the better one.