fix: parse inline Appium service arguments - #1294
Merged
KazuCocoa merged 2 commits intoSep 8, 2026
Merged
Conversation
Recognize --option=value when constructing the service status URL. Reproduced with Appium 3.7.0: the old client timed out while the configured endpoint returned HTTP200; inline, separate and alias formats start successfully with this patch. All 184 unit tests and make check passed.
Add 11 cases for inline host, port and base path, long and short forms, embedded equals, defaults and unrelated options. All 184 unit tests, Ruff, formatting and Mypy passed; real Appium startup confirmed four supported argument forms.
KazuCocoa
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AppiumServiceforwards--option=valuearguments to Appium, but its status URL parser only recognizes separate option/value tokens. For example, Appium starts successfully with--base-path=/wd/hub, while the client polls/statusand reports a startup timeout.Recognize inline values when extracting service arguments. Separate values and short aliases retain their existing behavior; values containing additional
=characters are preserved. The change only affects argument parsing.Validation
AppiumService.startagainst Appium 3.7.0 on an ephemeral localhost port with isolatedAPPIUM_HOME: before the fix, startup timed out while an independent request to the configured status endpoint received HTTP 200.=, defaults, and unrelated option names.make checkpassed (Ruff, formatting, Mypy over 320 source files).OpenAI Codex performed the implementation and local validation for this GitHub account; maintainer review is pending.
If accepted, please confirm whether this PR qualifies for compensation under the Appium contributor compensation scheme and the applicable amount. I understand that classification and payment remain at the project's discretion.