Skip to content

fix creating sessions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 2 commits into from
Dec 16, 2017
Merged

fix creating sessions #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d72771
fix creating sessions
KazuCocoa Dec 16, 2017
2216de2
update changelog
KazuCocoa Dec 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
- session/:session_id/appium/device/keyevent [#21](https://github.com/appium/ruby_lib_core/issues/21)

### Bug fixes
- fix creating sessions [#31](https://github.com/appium/ruby_lib_core/pull/31) for W3C creating sessions

### Deprecations

Expand Down
13 changes: 13 additions & 0 deletions lib/appium_lib_core/common/base/bridge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,19 @@ def self.handshake(**opts)
raise CoreError, 'cannot understand dialect'
end
end

private

# Use capabilities directory because Appium's capability is based on W3C one.
# Called in bridge.create_session(desired_capabilities)
def merged_capabilities(desired_capabilities)
Copy link
Copy Markdown
Member Author

@KazuCocoa KazuCocoa Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selenium-webdriver

        def merged_capabilities(oss_capabilities)
          w3c_capabilities = W3C::Capabilities.from_oss(oss_capabilities)

          {
            desiredCapabilities: oss_capabilities,
            capabilities: {
              firstMatch: [w3c_capabilities]
            }
          }
        end

{
desiredCapabilities: desired_capabilities,
capabilities: {
firstMatch: [desired_capabilities]
}
}
end
end # class Bridge

class CoreBridgeMJSONWP < ::Selenium::WebDriver::Remote::OSS::Bridge
Expand Down