fix creating sessions#31
Merged
KazuCocoa merged 2 commits intoappium:masterfrom Dec 16, 2017
Merged
Conversation
KazuCocoa
commented
Dec 18, 2017
|
|
||
| # Use capabilities directory because Appium's capability is based on W3C one. | ||
| # Called in bridge.create_session(desired_capabilities) | ||
| def merged_capabilities(desired_capabilities) |
Member
Author
There was a problem hiding this comment.
selenium-webdriver
def merged_capabilities(oss_capabilities)
w3c_capabilities = W3C::Capabilities.from_oss(oss_capabilities)
{
desiredCapabilities: oss_capabilities,
capabilities: {
firstMatch: [w3c_capabilities]
}
}
end
Member
Author
|
The reason why Ruby client filter the capabilities are valid only for the following capabilities for W3C specs:
KNOWN = [
:browser_name,
:browser_version,
:platform_name,
:accept_insecure_certs,
:page_load_strategy,
:proxy,
:set_window_rect,
:timeouts,
:unhandled_prompt_behavior,
# remote-specific
:remote_session_id,
# TODO (alex): deprecate in favor of Firefox::Options?
:accessibility_checks,
:device,
# TODO (alex): deprecate compatibility with OSS-capabilities
:implicit_timeout,
:page_load_timeout,
:script_timeout,
].freeze |
Member
Author
|
📝 add instead of skipping |
|
I'm going to make a PR for Appium today as well that merges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix createSession to work after appium/appium#9791
Appium: 1ac29f923658e50bd57fd0769dc781583426e542 (1.7.2-beta3)
test:
After fixing
Before