Skip to content

add adding appium-prefix#34

Merged
KazuCocoa merged 4 commits intoappium:masterfrom
KazuCocoa:adding_appium_prefix
Dec 19, 2017
Merged

add adding appium-prefix#34
KazuCocoa merged 4 commits intoappium:masterfrom
KazuCocoa:adding_appium_prefix

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

@KazuCocoa KazuCocoa commented Dec 19, 2017

ref: #31 (comment)

TODO

  • check compatibility for previous appium server
  • add a unit test
  • refactor include fixing rubocop
  • pass functional tests

Ruby

pry(#<Appium::Core::Base::Bridge>)> add_prefix(desired_capabilities)
=> #<Selenium::WebDriver::Remote::W3C::Capabilities:0x007fe564253748
 @capabilities=
  {:proxy=>nil,
   :platformName=>:ios,
   "appium:automationName"=>"XCUITest",
   "appium:app"=>"/Users/kazuaki/GitHub/ruby_lib_core/test/functional/app/UICatalog.app",
   "appium:platformVersion"=>"10.3",
   "appium:deviceName"=>"iPhone Simulator",
   "appium:useNewWDA"=>true,
   "appium:some_capability"=>"some_capability"}>

Appium

[HTTP] --> POST /wd/hub/session {"desiredCapabilities":{"platformName":"ios","automationName":"XCUITest","app":"/Users/kazuaki/GitHub/ruby_lib_core/test/functional/app/UICatalog.app","platformVersion":"10.3","deviceName":"iPhone Simulator","useNewWDA":true,"someCapability":"some_capability"},"capabilities":{"firstMatch":[{"platformName":"ios","appium:automationName":"XCUITest","appium:app":"/Users/kazuaki/GitHub/ruby_lib_core/test/functional/app/UICatalog.app","appium:platformVersion":"10.3","appium:deviceName":"iPhone Simulator","appium:useNewWDA":true,"appium:some_capability":"some_capability"}]}}
[debug] [MJSONWP] Calling AppiumDriver.createSession() with args: [{"platformName":"ios","automationName":"XCUITest","app":"/Users/kazuaki/GitHub/ruby_lib_core/test/functional/app/UICatalog.app","platformVersion":"10.3","deviceName":"iPhone Simulator","useNewWDA":true,"someCapability":"some_capability"},null,{"firstMatch":[{"platformName":"ios","appium:automationName":"XCUITest","appium:app":"/Users/kazuaki/GitHub/ruby_lib_core/test/functional/app/UICatalog.app","appium:platformVersion":"10.3","appium:deviceName":"iPhone Simulator","appium:useNewWDA":true,"appium:some_capability":"some_capability"}]}]
[debug] [BaseDriver] Event 'newSessionRequested' logged at 1513691671112 (22:54:31 GMT+0900 (JST))
[BaseDriver] ["appium:automationName","appium:app","appium:platformVersion","appium:deviceName","appium:useNewWDA","appium:some_capability"] are not standard capabilities and should have an extension prefix
[Appium] Creating new XCUITestDriver (v2.61.0) session
[Appium] Capabilities:
[Appium]   platformName: ios
[Appium]   automationName: XCUITest
[Appium]   app: /Users/kazuaki/GitHub/ruby_lib_core/test/functional/app/UICatalog.app
[Appium]   platformVersion: 10.3
[Appium]   deviceName: iPhone Simulator
[Appium]   useNewWDA: true
[Appium]   some_capability: some_capability
[BaseDriver] The following capabilities were provided, but are not recognized by appium: some_capability.
[BaseDriver] Session created with session id: f59e4bfd-3624-41de-8c8e-dbb7dddd87c5
[debug] [XCUITest] Current user: 'kazuaki'
[debug] [XCUITest] Current version of libimobiledevice: stable 1.2.0 (bottled), HEAD
[debug] [XCUITest] Xcode version set to '9.2'
[debug] [XCUITest] iOS SDK Version set to '11.2'

camel_cased_capability_names = snake_cased_capability_names.map(&w3c_capabilities.method(:camel_case))

unless snake_cased_capability_names.include?(capability_name) || camel_cased_capability_names.include?(capability_name)
name = "appium:#{capability_name}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we check if the capability already has the prefix?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The current implementation is so roughly. So, I'll implement some cases with adding test cases 👍

@KazuCocoa
Copy link
Copy Markdown
Member Author

@KazuCocoa KazuCocoa merged commit 9dd9c83 into appium:master Dec 19, 2017
@KazuCocoa KazuCocoa deleted the adding_appium_prefix branch December 19, 2017 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants