Support HTTP/HTTPS proxy agent in AppStoreServerAPIClient - #442
Open
shubhransh-gupta wants to merge 1 commit into
Open
Support HTTP/HTTPS proxy agent in AppStoreServerAPIClient#442shubhransh-gupta wants to merge 1 commit into
shubhransh-gupta wants to merge 1 commit into
Conversation
Resolves apple#352 by adding support for passing an optional HTTP/HTTPS agent (such as https-proxy-agent or http-proxy-agent) to AppStoreServerAPIClient via the constructor or through setAgent/getAgent methods, and passing it to fetch in makeFetchRequest.
Author
|
Hi @alexanderjordanbaker — Friendly reminder on this PR when you have time for a review. It resolves #352 by adding outbound proxy support (agent) to AppStoreServerAPIClient. Full TypeScript build and test suite pass with 100% test coverage. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #352.
Adds support for passing an HTTP/HTTPS agent (e.g. from
https-proxy-agent,http-proxy-agent, or standardhttp.Agent/https.Agent) toAppStoreServerAPIClientfor environments that require an outbound proxy or custom connection pooling.Changes
agentparameter toAppStoreServerAPIClientconstructor.setAgent(agent)andgetAgent()methods onAppStoreServerAPIClient.agenttofetchoptions inmakeFetchRequest.tests/unit-tests/api_client.test.tsverifyingagentconfiguration and getter/setter behavior.Verification
npm run buildcompleted successfully.npm testpassed all 22 test suites (346/346 unit tests).npm run build-docscompleted successfully.