Add --masked-path and --read-only-path to container machine create - #2081
Closed
adityabagchi24 wants to merge 1 commit into
Closed
Add --masked-path and --read-only-path to container machine create#2081adityabagchi24 wants to merge 1 commit into
adityabagchi24 wants to merge 1 commit into
Conversation
1 task
Contributor
|
@adityabagchi24 Thank you for the contribution. #2069 was merged prior to the creation of the issue, so we're going to close this one. Apologies for the confusion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes: #2077
container run/container createalready support--masked-pathand--read-only-path(PR #2069) to hide or protect sensitive paths inside a container. Container machines did not expose the same controls, so users had no way to mask or protect paths inside a machine's backing container.This PR adds
--masked-pathand--read-only-pathtocontainer machine create. The paths are persisted in the machine'sMachineConfiguration(create-time only, matching how the machine's platform is fixed) and applied to the backing container at boot. When not specified, the runtime OCI defaults apply; theNONEsentinel clears the defaults as it does forcontainer run/create. The effective paths are surfaced incontainer machine inspectundermaskedPathsandreadonlyPaths.MachineConfigurationusesdecodeIfPresent/encodeIfPresentwith explicitCodingKeysso existing machines from earlier revisions still decode, and new machines are readable by older revisions.